CDRIVER-4550 Do not use aligned_alloc() on Windows#1173
Merged
kevinAlbs merged 1 commit intomongodb:masterfrom Jan 10, 2023
jeroen:patch-1
Merged
CDRIVER-4550 Do not use aligned_alloc() on Windows#1173kevinAlbs merged 1 commit intomongodb:masterfrom jeroen:patch-1
kevinAlbs merged 1 commit intomongodb:masterfrom
jeroen:patch-1
Conversation
eramongodb
approved these changes
Jan 10, 2023
Contributor
eramongodb
left a comment
eramongodb
left a comment
There was a problem hiding this comment.
Suggested change should suffice as a short-term workaround for insufficient feature detection on Windows. Created CDRIVER-4549 as followup work to properly expand test coverage to include MSVC in C11 compatibility tests.
kevinAlbs
changed the title
kevinAlbs
pushed a commit
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kalibera found that
aligned_allocis not in stdlib.h and it is not supported in Windows, despite that it is in C11. See the footnote in: https://learn.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance:Actually
aligned_alloc()is also missing on MacOS 10.13 (which we also need) but I will patch that on my end because you are no longer offically supporting MacOS < 10.14.Downstream issues here: jeroen/mongolite#247 and jeroen/mongolite#244