Skip to content

LG-5777 chore(CI): NPM publish with OIDC #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheSonOfThomp merged 4 commits into from
Dec 9, 2025
Merged

LG-5777 chore(CI): NPM publish with OIDC #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e58fb2f
update node
TheSonOfThomp Dec 8, 2025
73093e6
update node in actions yaml
TheSonOfThomp Dec 8, 2025
6f6e231
Update release.yml
TheSonOfThomp Dec 8, 2025
949c4b9
Merge branch 'main' into at/LG-5777-npm
TheSonOfThomp Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ jobs:
icon-dist-${{ github.ref }}-

# Only setup & build if there was no build cache hit
- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
if: ${{ steps.build-cache.outputs.cache-hit != 'true' }}
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down Expand Up @@ -99,10 +99,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down Expand Up @@ -139,10 +139,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down Expand Up @@ -188,10 +188,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down Expand Up @@ -235,10 +235,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/react17.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ jobs:
tools/*/dist/*
key: ${{ runner.os }}-REACT17-build-cache-${{ hashFiles('package.json', 'pnpm-lock.yaml', '**/src/') }}

- name: Setup Node 18
- name: Setup Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22

- name: Install node-gyp
run: pnpm add --global node-gyp
Expand Down Expand Up @@ -92,10 +92,10 @@ jobs:
tools/*/dist/*
key: ${{needs.build.outputs.cache-primary-key}}

- name: Setup Node 18
- name: Setup Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22

- name: Install node-gyp
run: pnpm add --global node-gyp
Expand Down
35 changes: 12 additions & 23 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
branches:
- main

permissions:
id-token: write
contents: write

jobs:
build:
name: Build packages
Expand Down Expand Up @@ -45,11 +49,11 @@ jobs:
key: ${{ runner.os }}-build-cache-${{ hashFiles('package.json', 'pnpm-lock.yaml', '**/src/') }}

# Only setup & build if there was no build cache hit
- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
if: ${{ steps.build-cache.outputs.cache-hit != 'true' }}
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down Expand Up @@ -99,10 +103,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down Expand Up @@ -153,10 +157,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand All @@ -183,14 +187,6 @@ jobs:
tools/*/stories.js
key: ${{needs.build.outputs.cache-primary-key}}

- name: Updating .npmrc
run: |
cat << EOF > "$HOME/.npmrc"
//registry.npmjs.org/:_authToken=$NPM_TOKEN
EOF
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Version packages
id: changesets
uses: changesets/action@v1
Expand All @@ -200,13 +196,6 @@ jobs:
createGithubReleases: true
env:
GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
NPM_TOKEN: '${{ secrets.NPM_TOKEN }}'

- name: Debug changesets output
run: |
echo "Changesets output: ${{ steps.changesets.outputs }}"
echo "Changesets output type: ${{ toJSON(steps.changesets.outputs) }}"
echo "--------------------------------"
Comment on lines -205 to -209
Copy link
Copy Markdown
Collaborator

@stephl3 stephl3 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops should have dropped this, thank you!


release-aws:
name: Publish to AWS CodeArtifact
Expand All @@ -221,10 +210,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: 'pnpm'
cache-dependency-path: 'pnpm-lock.yaml'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sizeDiff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
with:
version: 10.18.3

- name: Use Node.js 18
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22

- uses: preactjs/compressed-size-action@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 18.20.8
nodejs 22.21.1
pnpm 10.18.3
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"private": true,
"engines": {
"node": ">= 18.20.8",
"node": ">= 22.21.0",
"pnpm": ">= 10.18.3"
},
"packageManager": "pnpm@10.18.3",
Expand Down
Loading