Skip to content

NODE-2717: Improve TS Typings #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 15, 2020
Merged

NODE-2717: Improve TS Typings #389

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a621c1
WIP: correct linting errors
nbbeeken Sep 2, 2020
4636828
chore: resolve all linter warnings
nbbeeken Sep 3, 2020
ebac0e6
fix: remove dom lib and fix buffer write calls
nbbeeken Sep 8, 2020
4a28e52
fix: toString toJSON methods on Binary
nbbeeken Sep 8, 2020
c27cc5f
Address comments
nbbeeken Sep 10, 2020
bc989fa
fix: EJSON API accepts primitives
nbbeeken Sep 11, 2020
2d437b1
remove null from db prop on DbRef
nbbeeken Sep 14, 2020
1d79e5a
fix: :art: Just use Document instead of BSONDocument
nbbeeken Sep 14, 2020
4576fab
fix: :fire: Remove custom CodeFunction type
nbbeeken Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
"ecmaVersion": 2017
},
"plugins": [
"prettier"
"prettier",
"eslint-plugin-tsdoc"
],
"rules": {
"prettier/prettier": "error",
"tsdoc/syntax": "warn",
"no-console": "off",
"eqeqeq": [
"error",
Expand All @@ -33,11 +35,15 @@
"null": "ignore"
}
],
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_"
}
],
"strict": [
"error",
"global"
],
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/no-var-requires": "off"
]
}
}
4 changes: 2 additions & 2 deletions api-extractor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"logLevel": "warning"
},
"ae-internal-missing-underscore": {
"logLevel": "none",
"logLevel": "error",
"addToApiReportFile": false
},
"ae-missing-release-tag": {
Expand All @@ -39,7 +39,7 @@
},
"ae-unresolved-link": {
"addToApiReportFile": false,
"logLevel": "none"
"logLevel": "error"
}
},
"tsdocMessageReporting": {
Expand Down
13 changes: 10 additions & 3 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,19 @@ module.exports = function (config) {
output: {
format: 'iife',
name: 'BSONtest',
sourcemap: true,
sourcemap: 'inline',
exports: 'named'
},
onwarn(warning) {
if (warning.code === 'CIRCULAR_DEPENDENCY') return;
console.warn(warning.toString());
}
},

// test results reporter to use
// possible values: 'dots', 'progress'
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
reporters: ['progress'],
reporters: ['mocha'],

// web server port
port: 9876,
Expand Down Expand Up @@ -79,6 +83,9 @@ module.exports = function (config) {

// Concurrency level
// how many browser should be started simultaneous
concurrency: 1
concurrency: 1,

// Console log print outs will be prefaced with `LOG:` for grep
client: { captureConsole: true }
});
};
1,424 changes: 740 additions & 684 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"eslint": "^7.7.0",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-tsdoc": "^0.2.6",
"karma": "^5.1.1",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^3.1.0",
Expand Down Expand Up @@ -78,7 +79,7 @@
"build:dts": "npm run build:ts && api-extractor run --typescript-compiler-folder node_modules/typescript --local && rimraf 'lib/**/*.d.ts*'",
"build:bundle": "rollup -c rollup.config.js",
"build": "npm run build:dts && npm run build:bundle",
"lint": "eslint -v && eslint --ext '.js,.ts' src test && tsc --noEmit",
"lint": "eslint -v && eslint --ext '.js,.ts' --max-warnings=0 src test && tsc -v && tsc --noEmit",
"format": "eslint --ext '.js,.ts' src test --fix",
"coverage": "nyc mocha test/node",
"prepare": "node etc/prepare.js",
Expand Down
Loading