Skip to content

Conversation

@lindseymoore
Copy link
Contributor

@lindseymoore lindseymoore commented Nov 12, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44953
Staging - https://deploy-preview-214--docs-spark-connector.netlify.app/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for docs-spark-connector ready!

Name Link
🔨 Latest commit 5c7ab50
🔍 Latest deploy log https://app.netlify.com/sites/docs-spark-connector/deploys/6744fa3fc70d620008b50db5
😎 Deploy Preview https://deploy-preview-214--docs-spark-connector.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some suggestions, but do what you think makes sense!

@lindseymoore lindseymoore merged commit 987747d into mongodb:master Nov 25, 2024
9 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)
lindseymoore added a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)

Co-authored-by: lindseymoore <[email protected]>
lindseymoore added a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)

Co-authored-by: lindseymoore <[email protected]>
lindseymoore added a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)

Co-authored-by: lindseymoore <[email protected]>
lindseymoore added a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)

Co-authored-by: lindseymoore <[email protected]>
lindseymoore added a commit that referenced this pull request Nov 25, 2024
* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)

Co-authored-by: lindseymoore <[email protected]>
shuangela added a commit that referenced this pull request Mar 6, 2025
* DOCSP-29861: Cleanup unused files (#200)

(cherry picked from commit 05f3125)

* DOCSP-40130 - Note on Sharded Partitioner (#201)

Co-authored-by: Nora Reidy <[email protected]>
(cherry picked from commit e25e13f)

* Add Netlify config files via upload

* DOCSP-42969 - remove nested admonitions (#204) (#208)

(cherry picked from commit b37226e)

Co-authored-by: Mike Woofter <[email protected]>

* DOCSP-44953 TOC Relabel (#214) (#217)

* DOCSP-44953 TOC Relabel

* edit

* Mike's Suggestions

* keep configure tls

(cherry picked from commit 987747d)

Co-authored-by: lindseymoore <[email protected]>

* (DOCSP-45749) Denests last phase 1 nested component for spark connector (#220) (#222)

* Add dependency installation to vale rule

(cherry picked from commit 989f378)

* [Spark] Remove autobuilder (#227) (#230)

(cherry picked from commit ca7f722)

Co-authored-by: Rachel Mackintosh <[email protected]>

* DOCSP-46719 Spark Guide 404 (#235) (#239)

(cherry picked from commit 671e355)

Co-authored-by: lindseymoore <[email protected]>

* DOCSP-31186 Add sections for connections (#243) (#248)

* add sections for connections

* fix vale

* fix vale flag

* fix ref

* fix typos

* change steps formatting

* change based on mikes feedback

* fix vale error

* change based on feedback

(cherry picked from commit 75df8c4)

---------

Co-authored-by: Michael Morisi <[email protected]>
Co-authored-by: Mike Woofter <[email protected]>
Co-authored-by: anabellabuckvar <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lindseymoore <[email protected]>
Co-authored-by: Sarah Simpers <[email protected]>
Co-authored-by: Rea Rustagi <[email protected]>
Co-authored-by: Rachel Mackintosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants