Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-33957: Alas but one fixes #932

Merged

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Nov 10, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-33957
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm. does it need meta keywords?

@ccho-mongodb
Copy link
Contributor Author

ccho-mongodb commented Nov 10, 2023

changes lgtm. does it need meta keywords?

No, it doesn't have code examples and all the headers describe the content pretty well. Let me know if you think of a keyword you think should be included. As Sarah Lin mentioned, meta keywords are not necessary on any page, but that "code example" could be helpful when it features one.

@ccho-mongodb ccho-mongodb merged commit 752177e into mongodb:master Nov 10, 2023
1 check passed
@ccho-mongodb ccho-mongodb deleted the DOCSP-33957-alas-and-cleanup branch November 10, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants