Skip to content

Conversation

@juliusgeo
Copy link
Contributor

No description provided.

@juliusgeo juliusgeo linked an issue Jul 31, 2020 that may be closed by this pull request
@juliusgeo juliusgeo linked an issue Jul 31, 2020 that may be closed by this pull request
# See the License for the specific language governing permissions and
# limitations under the License.

from pymongoexplain.explainable_collection import ExplainCollection
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@juliusgeo juliusgeo requested a review from ShaneHarvey July 31, 2020 19:21
changelog.rst Outdated

Changes in version 1.0.0
------------------------
= Initial ``ExplainCollection`` API

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be = or -?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it should be == because "changelog" is == on both top and bottom.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prashant was talking about the = Initial ``ExplainCollection`` API which needs to be - Initial...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@juliusgeo juliusgeo requested a review from prashantmital August 3, 2020 18:53
@juliusgeo juliusgeo requested a review from ShaneHarvey August 3, 2020 20:02
Copy link

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you will merge this before merging #36?

changelog.rst Outdated
------------------------
- ``ExplainCollection`` now importable from top level like so: ``from pymongoexplain import ExplainCollection``

Changes in version 1.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.0 -> 1.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@juliusgeo juliusgeo requested a review from ShaneHarvey August 4, 2020 19:59
@juliusgeo juliusgeo merged commit 5332935 into mongodb-labs:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add changelog Make ExplainCollection importable at module level

3 participants