This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Conversation
alcaeus
reviewed
Sep 13, 2024
Contributor
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
Changes LGTM - if the validate-workload-executor tasks completes successfully we can schedule a couple of the actual tests for PHP to see if everything works correctly.
Contributor
Author
|
Test successful for PHP. |
alcaeus
approved these changes
Sep 16, 2024
Contributor
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
Tested one test each on Atlas and Kind, both of which succeeded. Good to merge 👍
Jibola
pushed a commit
to Jibola/drivers-atlas-testing
that referenced
this pull request
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP tests broken by mongodb/mongo-php-library#1395
Instead of duplicating parts of the composer.json from the library, the dependencies are installed in the library directly.