fix: send 1 notification when switching connection

[SethFalco]

Description

Previously, when one had 2 connections, switching created 2 notifications.

This isn't a major problem, but is a little annoying.

This instead adds a quiet argument to #disconnect, and uses this argument when switching to skip the notification for disconnecting.

Screencast.from.2024-06-07.23-52-02.webm

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added

Not sure if this PR requires them as this only really updates the use of showInformationMessage which is mocked in the tests anyway.

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Happy to discuss UX if you have any feedback/opinions.

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[Anemy]

lgtm! One suggestion on a possible improvement.

[SethFalco]

I noticed you merged one of my PRs!
Just wanted to apologize for putting off these 2 that are still pending some work before they're ready to be reviewed. I'll try to get back to them tomorrow if I have time!

[alenakhineika]

Hey @SethFalco, do you feel like picking up these PRs? They have been open for quite a while :) Or can we safely close them at this point?

[SethFalco]

@alenakhineika Ahh, sorry about that! I actually forgot about this. A bit too much on my plate. 😓

If you don't mind, I would still like to address these PRs as I still use the extension. I can rebase and address it over the weekend.

And since last time I left maintainers hanging… if I don't update the PR for whatever reason by next week, feel free to close it. When I have time, I'm happy to open a new PR and reference this one.

[SethFalco]

I've amended the commit to mention the connection name on connect, disconnect, and both (switching between two connections).

I've included a video of all 3 notifications in the PR description. Any other feedback is welcome!

[alenakhineika]

Suggested change

	`Disconnected from ${prevConnectionName} and connected to ${nextConnectionName}.`
	`Changed the active connection to ${nextConnectionName}.`

We could simplify it and omit all logic responsible for prevConnectionName. Don't think the old connection details are important when connecting to a new cluster.

[SethFalco]

Rather than the word Changed, how about Set?

The word Changed implies the presence of a connection before, but if you'd like a single message for both an initial connection and changing connection, I think Set is more fitting.