chore: update mongosh #1168
Closed
chore: update mongosh #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the mongosh service provider. Among other things, this allows us to no longer be broken with mongosh VSCode tests
There was a problem hiding this comment.
Pull Request Overview
This PR updates mongosh dependencies to newer versions and removes the true parameter from close() method calls across the codebase. The changes align with updates in the mongosh service provider API, resolving compatibility issues with mongosh VSCode tests.
Key changes:
- Updated four mongosh packages to newer versions (3.18.0→3.23.0 for runtime/shell-api, 2.13.1→2.16.0 for i18n, 3.12.0→3.17.0 for service-provider-node-driver, 3.3.5→3.6.0 for service-provider-core)
- Removed boolean parameter from
close()method calls in three files
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates mongosh package versions to latest releases |
| src/mcp/mcpConnectionManager.ts | Removes boolean parameter from provider close call |
| src/language/worker.ts | Removes boolean parameter from serviceProvider close call |
| src/language/mongoDBService.ts | Removes boolean parameter from serviceProvider close call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This is done already with an older bump PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the mongosh service provider. Among other things, this allows us to no longer be broken with mongosh VSCode tests