This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
fix: properly remove environment variable #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`process.env.FOO = undefined` sets the env var to `'undefined'` as a string, but removing it entirely was almost certainly the intent here. Using `delete` here resolves that and stops Node.js from warning about it when `--pending-deprecation` is enabled. Refs: https://nodejs.org/api/deprecations.html#DEP0104
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.env.FOO = undefinedsets the env var to'undefined'as a string, but removing it entirely was almost certainly the
intent here.
Using
deletehere resolves that and stops Node.js from warningabout it when
--pending-deprecationis enabled.Refs: https://nodejs.org/api/deprecations.html#DEP0104