chore(tests): add tests for substrings, suffixes, prefixes with field level encryption COMPASS-8816 #2427
Conversation
gagik
force-pushed
the
gagik/update-mongo-crypt
branch
from
623b4fa to
68affa2
Compare
| "optionalDependencies": { | ||
| "kerberos": "2.1.0", | ||
| "mongodb-client-encryption": "^6.1.1" | ||
| "mongodb-client-encryption": "^6.3.0" |
There was a problem hiding this comment.
Seems like mongodb-client-encryption was previously bumped but this package was left at the old version; was this intentional?
There was a problem hiding this comment.
No, I think that's just an oversight (or maybe a bad merge conflict resolve?) 👍
gagik
force-pushed
the
gagik/update-mongo-crypt
branch
from
68affa2 to
28a4945
Compare
|
Just quoting myself from the ticket:
This should probably be an e2e test since we don't have the infrastructure for integration tests with the crypt_shared library in place in the shell-api package, and all similar tests are also e2e tests. And, well, we need the 8.1 crypt_shared library, and that's not released yet. |
gagik
force-pushed
the
gagik/update-mongo-crypt
branch
from
28a4945 to
a9a00c2
Compare
gagik
force-pushed
the
gagik/update-mongo-crypt
branch
from
a9a00c2 to
d6a3394
Compare
gagik
changed the title
…pdate-mongo-crypt
gagik
left a comment
gagik
left a comment
There was a problem hiding this comment.
Look good and much cleaner, thank you!
gagik
changed the title
gagik
changed the title
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive test coverage for field-level encryption features in MongoDB 8.2+, including support for $lookup operations with automatic encryption and queryable encryption with prefix/suffix/substring searches. The changes also update MongoDB version references from release candidates to stable versions.
- Adds test cases for $lookup aggregation pipeline operations with field-level encryption
- Implements comprehensive tests for queryable encryption prefix/suffix/substring functionality in both automatic and explicit modes
- Updates MongoDB 8.2 version references from RC to stable release
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testing/integration-testing-hooks.ts | Adds version parameter support to crypto library download function and new array sorting utility |
| packages/shell-api/src/field-level-encryption.spec.ts | Removes unreachable break statement and adds eslint disable comment |
| packages/e2e-tests/test/e2e-fle.spec.ts | Adds comprehensive FLE test suite for 8.2+ features including $lookup and substring search capabilities |
| packages/build/src/packaging/download-crypt-library.ts | Updates crypto library download logic to support specific version downloads |
| .evergreen/constants.js | Updates MongoDB 8.2 version from RC4 to stable release |
| .evergreen.yml | Updates test configuration to use stable 8.2.0 instead of RC versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Looks good, the check failure is confusing, going to try to run it again 🤷 |
It has previously been not possible to use $lookup stage of a pipeline with automatic encryption attached to it. This adds a test to verify it is possible along with another dependency bump.