Skip to content

Conversation

@nirinchev
Copy link
Collaborator

@nirinchev nirinchev commented Oct 20, 2025

Proposed changes

Reworks list-projects to return json instead of a table as LLMs have an easier time understanding json responses (our accuracy tests will occasionally fail because of that). Additionally, reworks the tests in projects.test.ts to be independent of one another.

@nirinchev nirinchev requested a review from a team as a code owner October 20, 2025 09:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reworks the list-projects Atlas tool to return JSON formatted responses instead of table format, making it easier for LLMs to understand. It also refactors the integration tests to be independent of each other by implementing proper test isolation and cleanup mechanisms.

Key Changes

  • Modified list-projects tool output from table format to structured JSON
  • Implemented proper test isolation with individual project creation and centralized cleanup
  • Removed shared argument object exports in favor of inline definitions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/tools/atlas/read/listProjects.ts Changed output format from table to JSON and inlined argument definitions
src/tools/atlas/create/createProject.ts Removed exported argument object in favor of inline definition
tests/integration/tools/atlas/projects.test.ts Reworked tests for independence with proper setup/cleanup and updated assertions for JSON format

@github-actions
Copy link
Contributor

📊 Accuracy Test Results

📈 Summary

Metric Value
Commit SHA 3ed76fbe65c85c5ce42782f27fae0cd0295eae4e
Run ID 0560fdaa-81f1-4068-a202-80e5a74a3c8b
Status done
Total Prompts Evaluated 76
Models Tested 1
Average Accuracy 92.0%
Responses with 0% Accuracy 6
Responses with 75% Accuracy 1
Responses with 100% Accuracy 71

📊 Baseline Comparison

Metric Value
Baseline Commit adbf3a0f05fadcd97b346d5adec091beba63b70f
Baseline Run ID cc48b882-7035-4c6e-b66d-039048e5f124
Baseline Run Status done
Responses Improved 5
Responses Regressed 5

📎 Download Full HTML Report - Look for the accuracy-test-summary artifact for detailed results.

Report generated on: 10/20/2025, 3:07:32 PM

@nirinchev nirinchev requested review from blva and Copilot October 21, 2025 09:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirinchev nirinchev merged commit ebe3d9f into main Oct 22, 2025
15 of 17 checks passed
@nirinchev nirinchev deleted the ni/fix-list-projects branch October 22, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants