Skip to content

Conversation

@himanshusinghs
Copy link
Collaborator

Proposed changes

With this PR we're removing the dependency on export tool input for constructing the name of the export without affecting the user experience in any way. The autocomplete request will now additionally match on export title to maintain high chances of autocompletions.

Checklist

@himanshusinghs himanshusinghs requested a review from a team as a code owner September 10, 2025 21:14
Copilot AI review requested due to automatic review settings September 10, 2025 21:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dependency on export tool input for generating export names while maintaining user experience through enhanced autocomplete functionality. The change simplifies export name generation by using only ObjectId-based names instead of incorporating database and collection names.

  • Simplified export name generation to use ObjectId only instead of database.collection.objectId format
  • Enhanced autocomplete to match on both export name and export title for better discoverability
  • Removed validation function validateExportName as it's no longer needed with simplified naming

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/tools/mongodb/read/export.ts Updated export name generation to use only ObjectId
src/resources/common/exportedData.ts Enhanced autocomplete to match on both export name and title
src/common/exportsManager.ts Removed validateExportName function and its usage
tests/unit/common/exportsManager.test.ts Removed tests for validateExportName function
tests/integration/resources/exportedData.test.ts Updated test to use more flexible matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

With this commit we're removing the dependency on export tool input for
constructing the name of the export without affecting the user
experience in any way.
@himanshusinghs himanshusinghs force-pushed the fix/MCP-189-export-tool-input-validation branch from c2cede1 to e41d3ea Compare September 11, 2025 15:15
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17649103551

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 81.18%

Files with Coverage Reduction New Missed Lines %
src/common/connectionManager.ts 6 87.78%
Totals Coverage Status
Change from base Build 17647912778: -0.1%
Covered Lines: 4772
Relevant Lines: 5782

💛 - Coveralls

@himanshusinghs himanshusinghs merged commit d6b84c7 into main Sep 11, 2025
17 of 18 checks passed
@himanshusinghs himanshusinghs deleted the fix/MCP-189-export-tool-input-validation branch September 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants