Skip to content

Conversation

@rose-m
Copy link
Contributor

@rose-m rose-m commented Jul 1, 2021

No description provided.

@rose-m rose-m self-assigned this Jul 1, 2021
@rose-m rose-m force-pushed the MONGOSH-860-add-is-digital-ocean-helper branch from c3502e4 to 091d8f5 Compare July 1, 2021 08:16
@addaleax
Copy link
Contributor

addaleax commented Jul 1, 2021

Is this something that would fit better into mongodb-cloud-info? (See also e.g. https://github.com/mongodb-js/vscode/blob/master/src/telemetry/connectionTelemetry.ts)

@rose-m
Copy link
Contributor Author

rose-m commented Jul 1, 2021

Mh... taking a look at what that cloud-info package does it determines the cloud provider based on IP Range. In that sense to me it looks to be more fitting here as we want to differentiate between our "Atlas" vs. "Digital Ocean" as the DB distributor.

@rose-m rose-m merged commit 9324e6b into master Jul 1, 2021
@rose-m rose-m deleted the MONGOSH-860-add-is-digital-ocean-helper branch July 1, 2021 08:46
@addaleax
Copy link
Contributor

addaleax commented Jul 1, 2021

Mh... taking a look at what that cloud-info package does it determines the cloud provider based on IP Range. In that sense to me it looks to be more fitting here as we want to differentiate between our "Atlas" vs. "Digital Ocean" as the DB distributor.

Honestly, that makes a good argument for also making Atlas detected in that package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants