Skip to content

Conversation

@kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Oct 1, 2025

Description

Merging this PR will:

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen self-assigned this Oct 1, 2025
@kraenhansen kraenhansen added no release notes Fix or feature not for release notes dependencies Pull requests that update a dependency file labels Oct 1, 2025

useLayoutEffect(() => {
if (autoFocus) {
throw new Error('BaseEditor is missing an implementation of autoFocus');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing an implementation and tests.

const editorRef = React.createRef<EditorRef>();
render(
<CodemirrorMultilineEditor text={'{}'} autoFocus ref={editorRef} />
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs an assertion that the editor is actually getting focussed.

@kraenhansen kraenhansen force-pushed the kh/leafygreen-update-october-2025 branch 6 times, most recently from 42a8977 to 105301d Compare October 7, 2025 14:52
@kraenhansen kraenhansen force-pushed the kh/leafygreen-update-october-2025 branch from 357fdc0 to 908f33c Compare October 10, 2025 11:40
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kraenhansen kraenhansen force-pushed the kh/leafygreen-update-october-2025 branch 2 times, most recently from 98bbd8e to 5b27667 Compare October 14, 2025 12:54
@kraenhansen kraenhansen force-pushed the kh/leafygreen-update-october-2025 branch from 5b27667 to b0cc3cd Compare November 5, 2025 12:59
@kraenhansen kraenhansen force-pushed the kh/leafygreen-update-october-2025 branch from d93da10 to f35840e Compare November 5, 2025 15:26
@kraenhansen kraenhansen force-pushed the kh/leafygreen-update-october-2025 branch from e50e450 to 5b5360f Compare November 6, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants