Skip to content

chore(databases-collections): refactor drop collection / drop database to drop namespace plugin COMPASS-7410 #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2023
Merged

chore(databases-collections): refactor drop collection / drop database to drop namespace plugin COMPASS-7410 #5096

merged 3 commits into from
Nov 10, 2023

Conversation

@gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Nov 10, 2023

Follow-up to #5085

  • Merges both plugins into one as their behavior is exactly the same
  • Adds functional tests for the plugin that we didn't have before
  • Sets up service injection for all required services
  • Removes a bunch of unneccessary code

@gribnoysup gribnoysup force-pushed the compass-7410-drop-namespace branch from 136a7c5 to d945d04 Compare November 10, 2023 12:20
@gribnoysup gribnoysup merged commit 909f12d into main Nov 10, 2023
@gribnoysup gribnoysup deleted the compass-7410-drop-namespace branch November 10, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gribnoysup @addaleax