This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the BSON-EXT library with the 4.0 version of our bson library required:
low_
andhigh_
tolow
andhigh
ObjectId
spelling for the oid class.Additionally we are able to do some major version changes which seem natural:
I also fixed the benchmark tests to work with the new style of exporting. I have kept the tests using the
createBSON
helper to keep the diff smaller, I have those changes locally that I can do in a separate PR.Another note, you'll notice the exported functions are called with:
.bind(BSON)
this is because they don't work if you pull them off the BSON instance. Without this,const {serialize} = require('bson-ext')
doesn't work for example.NODE-2944