Changes to Client/Server #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asppsa
force-pushed
the
server-fibers
branch
from
8985bd0
to
bc27fb4
Compare
asppsa
force-pushed
the
server-fibers
branch
4 times, most recently
from
4c28d41
to
b597fd8
Compare
asppsa
force-pushed
the
server-fibers
branch
from
b597fd8
to
e4827b8
Compare
asppsa
force-pushed
the
server-fibers
branch
from
e4827b8
to
08556fa
Compare
|
This is hanging in JRuby because |
This makes each connection on the server into a fiber that has its own state. In theory this should allow for easier implementation of things like `each_key` over the server.
This method returns true when the wrapper is running in server mode
This version has some threading fixes that we need.
asppsa
force-pushed
the
server-fibers
branch
from
a27b3fc
to
dc9ce9e
Compare
|
@asppsa that’s how the Thread.current “hash” works. Each fiber gets its own scoped storage. Instead maybe you should try thread_variable_set & thread_variable_get? See https://ruby-doc.org/core-2.4.1/Thread.html |
|
@brutuscat, the issue was resolved in JRuby 9.2.9.0 - jruby/jruby#5863 I think this PR actually works fine now - there's an issue with actionpack on Ruby 2.2, dropping 2.2 support will resolve that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serveris rewritten to use a fiber per connection. This makes handling stateful stuff like iterating over an enumerator easier.Serveralso uses_nonblockmethods to hopefully speed up IOeach_keyis implemented on the Server/ClientClientnow buffers reads if it doesn't manage to read the whole server response at once.