🐛 Fix namespace for Red Hat PURLs #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how they are formatted in OSV: https://security.access.redhat.com/data/osv/RHBA-2024:6680.json |
Test Results3 287 tests 3 283 ✅ 1m 39s ⏱️ Results for commit e5a9299. ♻️ This comment has been updated with latest results. |
czunker
force-pushed
the
czunker/redhat_purls
branch
from
70a188c to
140f074
Compare
chris-rock
reviewed
Feb 10, 2025
| @@ -80,8 +80,15 @@ func NewPackageURL(pf *inventory.Platform, t Type, name, version string, modifie | |||
| // and if the distro is set via labels, set it as a namespace | |||
| if pf.Labels != nil && pf.Labels[detector.LabelDistroID] != "" { | |||
| purl.Namespace = pf.Labels[detector.LabelDistroID] | |||
| } else if pf.Name != "" { | |||
| // Fallback to the platform name if the distro-id is not set | |||
| purl.Namespace = pf.Name | |||
There was a problem hiding this comment.
I changed this, so that we only rely on the platform name for the namespace.
czunker
force-pushed
the
czunker/redhat_purls
branch
from
140f074 to
51c261c
Compare
Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
czunker/redhat_purls
branch
from
51c261c to
e5a9299
Compare
chris-rock
approved these changes
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.