Skip to content

Commit

Permalink
Update go-github to v69
Browse files Browse the repository at this point in the history 
Signed-off-by: Salim Afiune Maya <[email protected]>
  • Loading branch information
@afiune
afiune committed Feb 5, 2025
1 parent 249137d commit cec1e69
Show file tree
Hide file tree
Showing 13 changed files with 34 additions and 28 deletions.
2 changes: 1 addition & 1 deletion providers/github/connection/connection.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

"github.com/bradleyfalzon/ghinstallation/v2"
"github.com/cockroachdb/errors"
"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"github.com/hashicorp/go-retryablehttp"
"github.com/mitchellh/hashstructure/v2"
"github.com/rs/zerolog"
Expand Down
38 changes: 21 additions & 17 deletions providers/github/connection/connection_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"os"
"testing"

"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"github.com/stretchr/testify/require"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/inventory"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/vault"
Expand All @@ -36,31 +36,35 @@ func TestGithubValidConnection_Private_Key(t *testing.T) {
pemData := pem.EncodeToMemory(privateKeyPEM)

_, err = NewGithubConnection(0, &inventory.Asset{
Connections: []*inventory.Config{{
Options: map[string]string{
OPTION_APP_ID: "123",
OPTION_APP_INSTALLATION_ID: "890",
Connections: []*inventory.Config{
{
Options: map[string]string{
OPTION_APP_ID: "123",
OPTION_APP_INSTALLATION_ID: "890",
},
Credentials: []*vault.Credential{
{
Type: vault.CredentialType_private_key,
Secret: pemData,
},
},
},
Credentials: []*vault.Credential{{
Type: vault.CredentialType_private_key,
Secret: pemData,
},
},
},
},
})
require.NoError(t, err)
}

func TestGithubValidConnection_Password(t *testing.T) {
_, err := NewGithubConnection(0, &inventory.Asset{
Connections: []*inventory.Config{{
Credentials: []*vault.Credential{{
Type: vault.CredentialType_password,
Secret: []byte("super_secret"),
Connections: []*inventory.Config{
{
Credentials: []*vault.Credential{
{
Type: vault.CredentialType_password,
Secret: []byte("super_secret"),
},
},
},
},
},
},
})
require.NoError(t, err)
Expand Down
2 changes: 1 addition & 1 deletion providers/github/go.mod
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/bradleyfalzon/ghinstallation/v2 v2.13.0
github.com/cockroachdb/errors v1.11.3
github.com/gobwas/glob v0.2.3
github.com/google/go-github/v68 v68.0.0
github.com/google/go-github/v69 v69.0.0
github.com/hashicorp/go-retryablehttp v0.7.7
github.com/mitchellh/hashstructure/v2 v2.0.2
github.com/rs/zerolog v1.33.0
Expand Down
2 changes: 2 additions & 0 deletions providers/github/go.sum
View file
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,8 @@ github.com/google/go-containerregistry v0.20.3 h1:oNx7IdTI936V8CQRveCjaxOiegWwvM
github.com/google/go-containerregistry v0.20.3/go.mod h1:w00pIgBRDVUDFM6bq+Qx8lwNWK+cxgCuX1vd3PIBDNI=
github.com/google/go-github/v68 v68.0.0 h1:ZW57zeNZiXTdQ16qrDiZ0k6XucrxZ2CGmoTvcCyQG6s=
github.com/google/go-github/v68 v68.0.0/go.mod h1:K9HAUBovM2sLwM408A18h+wd9vqdLOEqTUCbnRIcx68=
github.com/google/go-github/v69 v69.0.0 h1:YnFvZ3pEIZF8KHmI8xyQQe3mYACdkhnaTV2hr7CP2/w=
github.com/google/go-github/v69 v69.0.0/go.mod h1:xne4jymxLR6Uj9b7J7PyTpkMYstEMMwGZa0Aehh1azM=
github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/discovery.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"time"

"github.com/gobwas/glob"
"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"github.com/rs/zerolog/log"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/logger"
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/git.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
package resources

import (
"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/plugin"
)
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"context"
"time"

"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"github.com/rs/zerolog/log"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/plugin"
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github_org.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"time"

"github.com/cockroachdb/errors"
"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"github.com/rs/zerolog/log"
"go.mondoo.com/cnquery/v11/internal/workerpool"
"go.mondoo.com/cnquery/v11/llx"
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github_package.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"strconv"
"strings"

"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/plugin"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/util/convert"
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github_repo.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"sync"
"time"

"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"github.com/rs/zerolog/log"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/logger"
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github_team.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"strconv"
"strings"

"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/providers/github/connection"
)
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github_user.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"time"

"github.com/cockroachdb/errors"
"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"go.mondoo.com/cnquery/v11/llx"
"go.mondoo.com/cnquery/v11/logger"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/plugin"
Expand Down
2 changes: 1 addition & 1 deletion providers/github/resources/github_workflow.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"strconv"
"strings"

"github.com/google/go-github/v68/github"
"github.com/google/go-github/v69/github"
"go.mondoo.com/cnquery/v11/providers-sdk/v1/util/convert"
"go.mondoo.com/cnquery/v11/providers/github/connection"
"sigs.k8s.io/yaml"
Expand Down

1 comment on commit cec1e69

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: cec1e69 Previous: 5fa4441 Ratio
BenchmarkScan_SingleAsset 12442355394 ns/op 240171416 B/op 5360707 allocs/op 1949926955 ns/op 240161264 B/op 5360705 allocs/op 6.38
BenchmarkScan_SingleAsset - ns/op 12442355394 ns/op 1949926955 ns/op 6.38

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.