Feature/shayel/add support for multi region param interactive #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param' into feature/shayel/add_support_for_multi_region_param_interactive # Conflicts: # src/commands/code/status.ts
…param' into feature/shayel/add_support_for_multi_region_param_interactive # Conflicts: # src/commands/app/deploy.ts # src/commands/code/env.ts # src/commands/code/logs.ts # src/commands/code/push.ts # src/commands/code/status.ts # src/commands/utils/region.ts
…param' into feature/shayel/add_support_for_multi_region_param_interactive # Conflicts: # package.json
ShayElkana
changed the base branch from
master
to
feature/shayel/add_support_for_multi_region_param
maorb-dev
approved these changes
Jun 2, 2024
| @@ -34,3 +38,43 @@ export function addRegionToFlags<T>(flags: T): T { | |||
|
|
|||
| return flags; | |||
| } | |||
|
|
|||
| const regionsPrompt = async () => | |||
| PromptService.promptList('Choose region', [Region.US, Region.EU, Region.AU], Region.US); | |||
There was a problem hiding this comment.
does this use US as default? if so, why?
There was a problem hiding this comment.
US is the auto-selected option for the prompt
@maorb-dev
There was a problem hiding this comment.
wdym? lets talk about this: @ShayElkana
| try { | ||
| const path = getAppVersionsByAppIdUrl(appVersionId); | ||
| const url = appsUrlBuilder(path); | ||
| logger.debug(`fetching logs url: ${url}`); |
There was a problem hiding this comment.
Why? it's for --verbose
we already have something like this
@maorb-dev
| appVersionsSchema, | ||
| ); | ||
|
|
||
| return response.appVersion; |
There was a problem hiding this comment.
is it response.appVersion ? or response.appVersions ? because this is an array
There was a problem hiding this comment.
Why do you say it's returning an array this is a new endpoint that returns a single app version by id
@maorb-dev
|
|
||
| export const appVersionsSchema = z | ||
| .object({ | ||
| appVersion: appVersionSchema, |
There was a problem hiding this comment.
same comment - version? versions?
|
|
||
| export type AppVersion = z.infer<typeof appVersionSchema>; | ||
| export type Version = z.infer<typeof appVersionsSchema>; |
There was a problem hiding this comment.
again same comment- 1 Version like the type, or versions schema?
maorb-dev
reviewed
Jun 2, 2024
Comment on lines
6
to
7
| export type Version = z.infer<typeof appVersionHttpSchema>; | ||
| export type ListAppVersionsResponse = z.infer<typeof listAppVersionsSchema>; |
There was a problem hiding this comment.
line 7 is a good example- the schema is of the http response, and itself holds the schema of the entity. I would refactor like this:
Suggested change
| export type Version = z.infer<typeof appVersionHttpSchema>; | |
| export type ListAppVersionsResponse = z.infer<typeof listAppVersionsSchema>; | |
| export type GetAppVersionResponse = z.infer<typeof getAppVersionSchema>; | |
| export type ListAppVersionsResponse = z.infer<typeof listAppVersionsSchema>; |
maorb-dev
reviewed
Jun 2, 2024
| @@ -20,7 +20,7 @@ export const listAppVersionsSchema = z | |||
| }) | |||
| .merge(baseResponseHttpMetaDataSchema); | |||
|
|
|||
| export const appVersionsSchema = z | |||
| export const appVersionHttpSchema = z | |||
There was a problem hiding this comment.
Suggested change
| export const appVersionHttpSchema = z | |
| export const getAppVersionSchema = z |
ShayElkana
merged commit ac5e8ce
into
feature/shayel/add_support_for_multi_region_param
2 checks passed
ShayElkana
added a commit
that referenced
this pull request
Jun 3, 2024
* feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: add support for multi region param * feature: update version * feature: remove specific error * feature: version# * feature: [beta] mutli-region support basic cli flags * feature: [beta] mutli-region support basic cli flags * feature: [beta] fix imports * Feature/shayel/add support for multi region param interactive (#96) * feature: add support for multi region param * feature: add support for multi region param * feature: update version * feature: [beta] added interactive * feature: [beta] added interactive * feature: [beta] added interactive * feature: [beta] added interactive * feature: [beta] added interactive * feature: fix name of type * feature: fix version * feature: fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.