Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show static url in code:status table #32

Merged
merged 6 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mondaycom/apps-cli",
"version": "0.1.7",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check what is the version before merging, it will probably change to a different number that needs to get bumped

"version": "0.1.8",
"description": "A cli tool to manage apps (and monday-code projects) in monday.com",
"author": "monday.com Apps Team",
"type": "module",
Expand Down
6 changes: 4 additions & 2 deletions src/commands/code/status.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ import logger from 'utils/logger';

const printDeploymentStatus = (appVersionId: number, deploymentStatus: AppVersionDeploymentStatus) => {
const { deployment, status, error } = deploymentStatus;
const url: string | undefined = deployment?.url || 'none';
const url = deployment?.url || 'none';
const latestUrl = deployment?.latestUrl || 'none';
const errorMessage: string | undefined = error?.message;
const tableData = {
id: appVersionId,
status,
...(url && { url }),
url,
'static url (latest deployment)': latestUrl,
...(errorMessage && { errorMessage }),
};

Expand Down
1 change: 1 addition & 0 deletions src/services/schemas/push-service-schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const appVersionDeploymentStatusSchema = z
deployment: z
.object({
url: z.string(),
latestUrl: z.string(),
})
.optional(),
error: z
Expand Down
Loading