fixing the message users get when code:push to an app with latest liv…

…e version. https://monday.monday.com/boards/3670992828/pulses/6273008070
mondaycom · Sep 16, 2024 · 4b33f37 · 4b33f37
1 parent e4223da
commit 4b33f37
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/services/app-versions-service.ts b/src/services/app-versions-service.ts
@@ -35,22 +35,23 @@ export const listAppVersionsByAppId = async (appId: AppId): Promise<Array<AppVer
 
 export const defaultVersionByAppId = async (
   appId: AppId,
-  customLogMessage?: string,
-  useLiveVersion = false,
+  options: { customLogMessage?: string; useLiveVersion?: boolean } = {},
 ): Promise<AppVersion | undefined> => {
+  const defaults = { useLiveVersion: false };
+  options = { ...defaults, ...options };
   logger.info(`Getting the latest valid version for app id - ${appId}`);
 
   const appVersions = await listAppVersionsByAppId(appId);
   const latestVersion = appVersions.sort((a, b) => b.id - a.id)[0];
-  const allowedStatuses = useLiveVersion
+  const allowedStatuses = options.useLiveVersion
     ? [APP_VERSION_STATUS.LIVE, APP_VERSION_STATUS.DRAFT]
     : [APP_VERSION_STATUS.DRAFT];
 
   const validVersion = allowedStatuses.includes(latestVersion.status) ? latestVersion : undefined;
   if (validVersion) {
     logger.info(`Using version - ${validVersion?.id} for app id - ${appId}`);
   } else {
-    logger.info(customLogMessage || `No valid version found for app id - ${appId}`);
+    logger.info(options?.customLogMessage || `No valid version found for app id - ${appId}`);
   }
 
   return validVersion;

diff --git a/src/services/apps-service.ts b/src/services/apps-service.ts
@@ -77,7 +77,7 @@ export const cloneAppTemplateAndLoadManifest = async (
 };
 
 export const createFeatures = async (ctx: AppCreateCommandTasksContext) => {
-  const defaultVersion = await defaultVersionByAppId(ctx.appId!, undefined, false);
+  const defaultVersion = await defaultVersionByAppId(ctx.appId!);
   const baseUrl = await getTunnelingDomain();
   if (!defaultVersion) throw new Error(`No default version found for app id - ${ctx.appId}`);
   ctx.appVersionId = defaultVersion.id;

diff --git a/src/services/dynamic-choices-service.ts b/src/services/dynamic-choices-service.ts
@@ -58,7 +58,10 @@ export const DynamicChoicesService = {
     if (useLiveVersion) filterByStatus.push(APP_VERSION_STATUS.LIVE);
 
     if (appId && autoSelectVersion) {
-      const defaultVersion = await defaultVersionByAppId(appId, LIVE_VERSION_ERROR_LOG, useLiveVersion);
+      const defaultVersion = await defaultVersionByAppId(appId, {
+        customLogMessage: LIVE_VERSION_ERROR_LOG,
+        useLiveVersion: useLiveVersion,
+      });
       if (!defaultVersion) throw new Error(`No default version found for app id - ${appId}`);
 
       return { appId, appVersionId: defaultVersion.id };