chore(router): remove mondaytweaks memory-leak flags after upstream #3035 - #9
Merged
arutkowski00 merged 1 commit intoJul 7, 2026
Conversation
…undergraph#3035 Local reload benchmarks showed ~7.6 MB/reload retained with flags off vs pre-fix ~260 MB, so the flag-guarded reload cleanup is redundant with upstream graphMux closure fixes. Drop the eight memory-leak toggles and their guarded code while keeping behavior/perf tweaks and the structural schemaDocument removal in cached plans.
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closeOncefrom fix(router): join websocket connection handlers before executor.Close to fix shutdown data race #8.Removed flags / code
ClearSlowPlanCacheOnCloseCallOnRouterConfigReloadOnHotReloadOnRouterConfigReloadin hot-reload pathSkipPlanCacheOnEvictDuringMuxShutdownDrainWebsocketSubscriptionsBeforeCacheCloseCloseExecutorOnGraphMuxShutdownExecutor.Close()+gm.executorNilGraphMuxCachesOnShutdownResetExecutionConfigProtoOnReloadproto.Resetafter manifest reloadSkipManifestReloadWhenMapperUnchangedStill present (not flag-guarded):
schemaDocumentremoved fromplanWithMetaData(structural ~200MB pin fix from #3).Test plan
go test ./core/... ./pkg/slowplancache/...— 406 passedscripts/run-memory-tweak-validation.sh) on staging manifest — confirm retained inuse stays well below pre-fix baseline