Fix monasca-aggregator build #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building of confluent-kafka-go is currently broken on go v1.9.4 which is currently shipping with alpine:edge [1]. This switches the image build to alpine:3.7 which does now have this problem, however we may run into issues upgrading to later versions if confluent-kafka-go doesn't find a workaround for the underlying problem. [1] confluentinc/confluent-kafka-go#137 Signed-off-by: Tim Buckley <[email protected]>
Signed-off-by: Tim Buckley <[email protected]>
rbrndt
approved these changes
Feb 20, 2018
aadams19
previously approved these changes
Feb 20, 2018
Signed-off-by: Tim Buckley <[email protected]>
aadams19
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building of confluent-kafka-go is currently broken on go v1.9.4 which
is currently shipping with alpine:edge [1]. This switches the image
build to alpine:3.7 which does now have this problem, however we may
run into issues upgrading to later versions if confluent-kafka-go
doesn't find a workaround for the underlying problem.
[1] confluentinc/confluent-kafka-go#137
Signed-off-by: Tim Buckley [email protected]