fix(actions): attempt at fixing cache-dependency-path #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InteractiveTimmy
requested changes
Aug 14, 2023
There was a problem hiding this comment.
the cache-dependency-path should be the path to the localized package-lock.json or yarn.lock file, the file at the value of this parameter is read by actions/setup-node@3, then the contents are processed similar to the native GitHub Actions hashFiles() call within actions/setup-node@3.
See actions/setup-node@3 documentation. Let me know if you disagree and believe these initial changes are correct.
See this related issue, it seems this was an API-breaking change they didn't account for.
InteractiveTimmy
approved these changes
Aug 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding cache-dependency-path to setup node.
I think this will fix https://github.com/momentum-design/momentum-design/actions/runs/5857942350/job/15888490025
Links
https://github.com/momentum-design/momentum-design/actions/runs/5857942350/job/15888490025