-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changes name of delete command #159
Conversation
@@ -110,7 +110,7 @@ enum CloudSignupCommand { | |||
#[derive(Debug, StructOpt)] | |||
enum CacheCommand { | |||
#[structopt(about = "Create a cache")] | |||
Create { | |||
CreateCache { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this would make people need to type
momento cache createcache --name cachename
right? I'm not convinced that writing cache again right after writing cache is removing any lack of clarity that already exists. Can you explain the motivation behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kvcache he was going directly off this ticket per @danielamiao comments. Im updating pr w/ ticket link as well now.
#145
I know we had talked as well to collapse commands down to root of CLI but would rather that be follow up pr then after this initial refactor for ticket @WillRInternship working on now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this boils down to momento cache create-cache --name cachename
with how clap parses commands currently just FYI it adds in the -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not aligned... let's take this to slack or zoom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok we clarified w/ @danielamiao we want to move down to root. @WillRInternship check out comment here.
#145 (comment)
Id still from implementation wise get delete added first make sure works as you would expect. Then can make a follow up commit to get rid of the cache
subcommand and move all the commands down to root of CLI like @danielamiao saying in ticket.
Closing this pr for now and will come back to work on the updates. |
Closes #145