Skip to content

chore: upgrade momento sdk - consistency, less copypasta #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvcache merged 5 commits into from
May 21, 2022
Merged

chore: upgrade momento sdk - consistency, less copypasta #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce2cb47
chore: consistency and less copypasta
kvcache May 20, 2022
e24f9e1
wip: see if the github runner\'s rust builds on windows
kvcache May 20, 2022
a204be8
wip: maybe an edition bump will change this but i really doubt it
kvcache May 20, 2022
ea9d170
i think cmake is being tried because protoc is not installed on the g…
kvcache May 20, 2022
f87c963
drop windows lint, linux lint is enough
kvcache May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ jobs:
needs: release
steps:
- uses: actions/checkout@v2
- name: i guess windows-latest does not have protoc or cmake but we need protoc
run: choco install protoc
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,6 @@ jobs:
- name: Rigorous lint via Clippy
run: cargo clippy --all-targets --all-features -- -D warnings

rustfmt-windows:
name: Style & Lint - Windows
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: rustfmt
run: cargo fmt -- --check
- name: Rigorous lint via Clippy
run: cargo clippy --all-targets --all-features -- -D warnings

build:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -79,6 +69,8 @@ jobs:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: i guess windows-latest does not have protoc or cmake but we need protoc
run: choco install protoc
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
Expand Down
Loading