Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changes name of delete command #159

Closed
wants to merge 5 commits into from
Closed

feat: changes name of delete command #159

wants to merge 5 commits into from

Conversation

kiwisurgen
Copy link

@kiwisurgen kiwisurgen commented Jul 7, 2022 •
edited by eaddingtonwhite
Loading

Closes #145

$./momento cache
momento-cache 
Interact with caches

USAGE:
    momento cache [OPTIONS] <SUBCOMMAND>

OPTIONS:
    -h, --help       Print help information
        --verbose    

SUBCOMMANDS:
    create-cache    Create a cache
    delete-cache    Delete the cache
    get             Get an item from the cache
    help            Print this message or the help of the given subcommand(s)
    list-cache      List all caches
    set             Store a given item in the cache

kvcache
kvcache reviewed Jul 7, 2022
View reviewed changes
src/main.rs
@@ -110,7 +110,7 @@ enum CloudSignupCommand {
#[derive(Debug, StructOpt)]
enum CacheCommand {
#[structopt(about = "Create a cache")]
Create {
CreateCache {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this would make people need to type

momento cache createcache --name cachename

right? I'm not convinced that writing cache again right after writing cache is removing any lack of clarity that already exists. Can you explain the motivation behind this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kvcache he was going directly off this ticket per @danielamiao comments. Im updating pr w/ ticket link as well now.
#145

I know we had talked as well to collapse commands down to root of CLI but would rather that be follow up pr then after this initial refactor for ticket @WillRInternship working on now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this boils down to momento cache create-cache --name cachename with how clap parses commands currently just FYI it adds in the -

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not aligned... let's take this to slack or zoom.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok we clarified w/ @danielamiao we want to move down to root. @WillRInternship check out comment here.
#145 (comment)

Id still from implementation wise get delete added first make sure works as you would expect. Then can make a follow up commit to get rid of the cache subcommand and move all the commands down to root of CLI like @danielamiao saying in ticket.

@eaddingtonwhite eaddingtonwhite mentioned this pull request Jul 11, 2022
Open
@poppoerika
Copy link
Contributor

Closing this pr for now and will come back to work on the updates.
cc @cprice404

@poppoerika poppoerika closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvcache kvcache kvcache left review comments

@eaddingtonwhite eaddingtonwhite Awaiting requested review from eaddingtonwhite

@cprice404 cprice404 Awaiting requested review from cprice404

@danielamiao danielamiao Awaiting requested review from danielamiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Delete functionality
4 participants
@kiwisurgen @poppoerika @eaddingtonwhite @kvcache