Yet another PR adding TypeScript declarations #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Any chance of this getting merged? |
|
As an FYI, I have closed #444 as it appears the issue I was having has been resolved. |
|
Can this get merged? Or conflicts fixed, then merged? I had to take the typings from this PR and create my own inside my app to remove errors. |
|
Why not merge this? |
|
When will this PR be merged? |
…named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export
cspotcode
force-pushed
the
feature/ts-declarations
branch
from
1f2ef84 to
0016470
Compare
|
I rebased against the latest master. Declaration tests are still passing; the failures are due to failures from the master branch, not this PR. Please let me know if there's anything I can do to help get this merged. |
|
I copied |
|
Hey guys, any update on where this is at? |
ellenaua
added a commit
that referenced
this pull request
May 16, 2020
* Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]>
ellenaua
added a commit
that referenced
this pull request
May 17, 2020
* Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]>
ellenaua
added a commit
that referenced
this pull request
May 17, 2020
* Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]>
ellenaua
added a commit
that referenced
this pull request
May 17, 2020
…856) * Develop -> Master release 0.5.29 (#849) (#854) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails (#855) * Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Release0.5.31 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]>
ellenaua
added a commit
that referenced
this pull request
May 23, 2020
* Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise in Node 4 and 6 build fails (#856) * Develop -> Master release 0.5.29 (#849) (#854) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails (#855) * Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Release0.5.31 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Added copyright info Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]>
|
This is a potentially breaking change with respect to type-checking, because it will silently override |
ellenaua
added a commit
that referenced
this pull request
Nov 10, 2021
* Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise in Node 4 and 6 build fails (#856) * Develop -> Master release 0.5.29 (#849) (#854) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails (#855) * Develop -> Master release 0.5.29 (#849) * Merged @adgrace pull request #410 * Merged @adgrace pull request #410 * Bugfix: zone country is detected incorrect if link is used * Bugfix: zone country is detected incorrect if link is used * Decrease build size * Order zones by name * Updated 2019c files * Updated changelog * Resolve es6 loading issue where moment is undefined * Removed node 4 and 6 from travis.yml * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Fixed changelog to represent proper release versions (#839) * Fixed changelog to represent proper release versions * Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions. Co-authored-by: Alexandre Couillard <[email protected]> * Resolves es6 module loading issue * Corrected version numbers (#845) Version numbers were incorrect so fixed it. * Resolves es6 module loading issue * Yet another PR adding TypeScript declarations (#530) * Adds TypeScript declarations for moment-timezone * Remove unnecessary `moment.` qualification in typings * Move exported types to top-level so that they can all be imported as named imports - Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export * tsc invocation always uses locally installed tsc Co-authored-by: Elena Sharovar <[email protected]> * Release 0.5.29 * Release 0.5.29 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Fixing Grunt version to 1.0.4 otherwise it fails Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Release0.5.31 Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]> * Added copyright info * 2021a (#928) * Create issue_template.md * 2021a (#927) * 2021a * 2021a * 2021e Co-authored-by: Brinley Ang <[email protected]> Co-authored-by: praneeth-m <[email protected]> Co-authored-by: Jackalex36 <[email protected]> Co-authored-by: Alexandre Couillard <[email protected]> Co-authored-by: Andrew Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript declarations for moment-timezone. They have JSDoc comments, integrate with the typings included in
moment, and have tests.Fixes issues #341 and #370, replaces & improves upon PR #444.