Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lowercase t and z to ISO parsing regexes #1624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add lowercase t and z to ISO parsing regexes #1624

wants to merge 1 commit into from

Conversation

benjamin-pike
Copy link

@benjamin-pike benjamin-pike commented May 10, 2024 •
edited
Loading

Adds the ability for DateTime.fromISO to parse ISO strings containing lowercase t and z characters.
Resolves issue 1610

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 10, 2024 •
edited
Loading

CLA Signed

  • ✅login: benjamin-pike / (74d3a6f)

The committers listed above are authorized under a signed CLA.

@icambron
Copy link
Member

icambron commented Aug 3, 2024

This needs unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateTime.fromISO does not work with lowercase 't'
2 participants
@benjamin-pike @icambron