Fixing issue #1165 and testing

moment · Apr 21, 2022 · c55a8be · c55a8be
1 parent aa6ab8b
commit c55a8be
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/impl/diff.js b/src/impl/diff.js
@@ -1,7 +1,7 @@
 import Duration from "../duration.js";
 
 function dayDiff(earlier, later) {
-  const utcDayStart = (dt) => dt.toUTC(0, { keepLocalTime: true }).startOf("day").valueOf(),
+  const utcDayStart = (dt) => dt.toUTC(0).startOf("day").valueOf(),
     ms = utcDayStart(later) - utcDayStart(earlier);
   return Math.floor(Duration.fromMillis(ms).as("days"));
 }

diff --git a/test/datetime/diff.test.js b/test/datetime/diff.test.js
@@ -303,6 +303,16 @@ test("DateTime#diff results works when needing to backtrack months", () => {
   expect(diff.days).toBe(1);
 });
 
+test("DateTime#diff works when date has a zone object", () => {
+  const start = DateTime.fromISO("2022-05-05T23:00", { zone: "UTC" });
+  const end = DateTime.fromISO("2022-05-10T00:00", { zone: "Europe/Madrid" });
+
+  const diff = end.diff(start, ["days", "hours", "minutes"]).toObject();
+  expect(diff.days).toBe(3);
+  expect(diff.hours).toBe(23);
+  expect(diff.minutes).toBe(0);
+});
+
 //------
 // diffNow
 //-------