Handle invalid Durations in toHuman and toMillis (#1489)

moment · Aug 22, 2023 · 559a212 · 559a212
1 parent bc43bbc
commit 559a212
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/duration.js b/src/duration.js
@@ -462,6 +462,8 @@ export default class Duration {
    * ```
    */
   toHuman(opts = {}) {
+    if (!this.isValid) return INVALID;
+
     const l = orderedUnits
       .map((unit) => {
         const val = this.values[unit];
@@ -576,9 +578,11 @@ export default class Duration {
    * @return {number}
    */
   toMillis() {
+    if (!this.isValid) return NaN;
+
     let sum = this.values.milliseconds ?? 0;
     for (let unit of reverseUnits.slice(1)) {
-      if (this.values?.[unit]) {
+      if (this.values[unit]) {
         sum += this.values[unit] * this.matrix[unit]["milliseconds"];
       }
     }

diff --git a/test/duration/invalid.test.js b/test/duration/invalid.test.js
@@ -31,3 +31,23 @@ test("Diffing invalid DateTimes creates invalid Durations", () => {
 test("Duration.invalid produces invalid Intervals", () => {
   expect(Duration.invalid("because").isValid).toBe(false);
 });
+
+test("Duration.toMillis produces NaN on invalid Durations", () => {
+  expect(Duration.invalid("because").toMillis()).toBe(NaN);
+});
+
+test("Duration.as produces NaN on invalid Durations", () => {
+  expect(Duration.invalid("because").as("seconds")).toBe(NaN);
+});
+
+test("Duration.toHuman produces null on invalid Durations", () => {
+  expect(Duration.invalid("because").toHuman()).toBe("Invalid Duration");
+});
+
+test("Duration.toISO produces null on invalid Durations", () => {
+  expect(Duration.invalid("because").toISO()).toBeNull();
+});
+
+test("Duration.toFormat produces Invalid Duration on invalid Durations", () => {
+  expect(Duration.invalid("because").toFormat("s")).toBe("Invalid Duration");
+});