Update to prevent divide by zero in future version of mstar#994
Conversation
Also standardizing capitalization of names of some variables (MStar vs mstar)
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #994 +/- ##
============================================
- Coverage 43.24% 43.24% -0.01%
============================================
Files 213 213
Lines 62214 62216 +2
============================================
Hits 26905 26905
- Misses 35309 35311 +2
Continue to review full report at Codecov.
|
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree with the logic with this change. It remains a mystery to me why the product of MStar and UStar should be zero in an ocean cell, although this was obviously what was happening at the beginning of the SPEAR test cases where @wfcooke was encountering the problems.
I also appreciate the changes for more consistent capitalization of variables. Assuming that this passes the pipeline tests, this PR should be accepted.
|
The pipeline testing this PR has passed at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/8860. |
Also standardizing capitalization of names of some variables (MStar vs mstar)