*Add new update_segment_tracer_reservoirs routine#987
Merged
Conversation
- The OBC tracer reservoirs were being updated in MOM_tracer_advect - twice each! Update them separately after tracer advection. - The OBC tracer lengthscale was being cubed to get the volume. Change that to a lengthscale times the face area where the advection is happening. - Changes answers if the tracer lengthscales were not set to zero.
- Could make it more verbose to let the user know which data are missing.
adcroft
approved these changes
Aug 30, 2019
Collaborator
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Testing on gaea at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/8795
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #987 +/- ##
===========================================
+ Coverage 43.17% 43.2% +0.02%
===========================================
Files 213 213
Lines 62219 62211 -8
===========================================
+ Hits 26866 26877 +11
+ Misses 35353 35334 -19
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
twice each! Update them separately after tracer advection.
that to a lengthscale times the face area where the advection is
happening.