Adding scale_factor and add_offset for horiz_interp_and_extrap_tracer_record#960
Merged
adcroft merged 1 commit intoJul 23, 2019
Conversation
…netCDF inputs in horiz_interp_and_extrap_tracer_record
adcroft
reviewed
Jul 23, 2019
Collaborator
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Looks correct to me.
Testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/8520
adcroft
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MOM_horizontal_regridding.F90 when reading from NetCDF in subroutine horiz_interp_and_extrap_tracer_record we do not currently check for offset and scale factors. This adds the capability to read and use each factor, defaulting to 0 and 1 respectively if they are absent.
These adjustments are not applied to values that have the value of _FillValue.
Tested 1 case initializing temperature and salinity from a file that does not include these factors and got the same answers with this code change. Tested another case that does include these factors for the temperature and salinity files and now successfully initialize with the correct values.