Anisotropic horizontal viscosity#799
Merged
Merged
Conversation
Collaborator
adcroft
commented
Jun 25, 2018
adcroft
commented
- Adds anisotropic viscosity following Large and Mcwilliams, 2003.
- Includes documentation.
- Only fixed angle relative to grid actually implemented here but place holders for compass and flow based anisotropy are provided.
- The logic for constructing viscosity involved nested if's and
alternate pathways.
- This refactor avoids large pathway branches and has not nested
if's, thereby simplifying the logic:
- The only case where extra steps occur are when Smagorinsky and
Leith are both disabled and better_bound is enabled. In this case
more conditionals are encountered sequentially.
- Added comments to:
- indicate contributions that are resolution scaled or not;
- indicate contributions that are additive rather than maxed.
- Added equations for anisotropic viscosity (yet to be implemented) - Also corrected missing factor of 1/2 in documentation of isotropic viscosity.
- Added parameters to control anisotropic viscosity - Added allocatable storage for factors in the anisotropic stress tensor - Set factors for i-oriented tensor - Actual viscosity not used yet
- The tension component of the stress tensor has an enhanced viscosity
made from an offset + a rotated component.
- The rotated component is often zero hence writing as ( 1 - stuff )
resolves to a constant offset where appropriate.
- Added run-time specification of n1,n2 for mode 0
- The strain component of viscosity had the order of bounding/scaling reversed in a previous commit. This doesn't seem to change answers but probably could in some special cases.
Collaborator
Author
Contributor
|
The proper reference is Smith and McWilliams, 2003. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.