MOM6 code cleanup#763
Merged
Merged
Conversation
Replaced 'if(' with 'if (' and 'elseif(' with 'elseif (' throughout the MOM6
code base to follow MOM6 coding conventions. All answers are bitwise identical.
Replace the older Fortran syntax '.ge.', '.gt.', '.lt.', and '.le.' with the clearer and more succinct syntax '>=', '>', '<', and '<='. All answers are bitwise identical.
Replace the older Fortran syntax '.eq.', and '.ne.' with the clearer and more succinct syntax '==' and '/='. All answers are bitwise identical.
Added dOxyGen comments for all of the subroutines and their arguments in the PXM_functions and regrid_... modules in src/ALE. Also shortened the name of several variables. All answers are bitwise identical.
Combined i- and j- loops with the same interior code on the same line. All answers are bitwise identical.
Renamed several ..._coeffients variables as ..._coef, for brevity of expressions. All answers are bitwise identical.
Added dOxyGen comments for all of the subroutines and their arguments in the coord_... modules in ALE. Also shortened the name of several variables. All answers are bitwise identical.
Changed 'call sub (...)' to 'call sub(...)' in several places. All answers are bitwise identical, and only white-space is changed.
Changed 'array (...)' to 'array(...)' and 'call sub (...)' to 'call sub(...)' in numerous places in MOM_ice_shelf.F90. All answers are bitwise identical, and only white-space is changed.
Semicolons are not proper punctuation to end a sentence; instead they connect independent clauses. MOM6 is written in Fortran, not C; therefore trailing semicolons are unnecssary and have been removed. All answers are bitwise identical.
Added dOxyGen comments for all routines and arguments in MOM_debugging.F90. All answers are bitwise identical.
Added dOxyGen comments for all routines and arguments in MOM_checksums.F90. All answers are bitwise identical.
Added dOxyGen comments for all routines and arguments in MOM_safe_alloc.F90. All answers are bitwise identical.
Added dOxyGen comments for all routines and arguments in MOM_file_parser.F90. All answers are bitwise identical.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a series of 15 commits that clean up or improve the documentation in widespread locations throughout the MOM6 code. Included commits include: