Neutral Diffusion: Add option for discontinuous reconstruction of T/S#553

Merged

Hallberg-NOAA merged 46 commits into

mom-ocean:dev/gfdlfrom

ashao:ndiff_update_neutral_position

Aug 16, 2017

Commits on May 17, 2017

Neutral positions by discontinuous PPM
Andrew Shao
committed

Commits on May 18, 2017

Additional changes to make sure that code compiles. Development of the
Andrew Shao
committed

Commits on Jun 20, 2017

Merge branch 'dev/master' of https://github.com/NOAA-GFDL/MOM6 into ndiff_update_neutral_position
Andrew Shao
committed

Commits on Jun 22, 2017

Some initial changes for the neutral surface positions found using a discontinuous reconstruction
Andrew Shao
committed

Commits on Jun 23, 2017

Discontinuous T/S reconstruction still does not work correctly because
Andrew Shao
committed

Commits on Jun 28, 2017

Make changes based on python prototyping of the discontinuous version of
Andrew Shao
committed
Fixed which pressure array is supposed to be used
Andrew Shao
committed

Commits on Jun 29, 2017

Discontinuous reconstruction of neutral diffusion is working better, but
Andrew Shao
committed

Commits on Jul 11, 2017

Updated the discontinuous reconstruction, but not working as expected, so
Andrew Shao
committed

Commits on Jul 13, 2017

Newer algorithm works away from top and bottom boundaries
Andrew Shao
committed
Fixed conflict with upstream
Andrew Shao
committed
Neutral surface discontinuous reconstuction with no boundary extrap
Andrew Shao
committed
Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into ndiff_update_neutral_position
Andrew Shao
committed
Change module name variable from mod to mdl
Andrew Shao
committed

Commits on Jul 17, 2017

Replace column reconstruction with functions from PPM_routines.F90
Andrew Shao
committed
Replace more routines with those from MOM_remapping.F90
Andrew Shao
committed

Commits on Jul 18, 2017

Continue to replace discontinuous reconstruction with MOM_remapping
Andrew Shao
committed

Commits on Jul 19, 2017

Need to figure out why some kind of spurious perfectly horizontal diffusion
Andrew Shao
committed

Commits on Jul 20, 2017

Working as expected in z* (not rho) coordinate mode. However, do need to
Andrew Shao
committed
Replace the linear interpolation used to calculate temperature gradients
Andrew Shao
committed

Commits on Jul 22, 2017

Included new functions to calculate the second derivatives of density from
Andrew Shao
committed
Begin to add a rootfinder to solve for the position of a nuetral surface
Andrew Shao
committed
Add scalar version of routines for higher order density derivatives
Andrew Shao
committed
Finished at least the original code for the refinement of neutral position.
Andrew Shao
committed

Commits on Jul 23, 2017

Add an extractor routine for the remapping control structure
Andrew Shao
committed
Refinement of neutral surface position routine is ready to be tested
Andrew Shao
committed

Commits on Jul 26, 2017

Root-finding algorithm works as expected. Need to replace the current
Andrew Shao
committed

Commits on Jul 27, 2017

Added options to choose (exclusively) between bisection, Newton's, or
Andrew Shao
committed

Commits on Jul 31, 2017

Update MOM_EOS and MOM_EOS_Wright to include calculation of second
Andrew Shao
committed
Update neutral diffusion with the following:
Andrew Shao
committed
Fixed some bugs in refine_nondim_position
Andrew Shao
committed

Commits on Aug 3, 2017

Realized that same_direction should be false if reached_bottom is true.
Andrew Shao
committed
Write unit tests for refine_nondim_position. Next up is the discontinuous
Andrew Shao
committed

Commits on Aug 7, 2017

-Adds unit tests for discontinuous routines
Andrew Shao
committed
Make convergence criteria runtime parameters as opposed to hardcoded
Andrew Shao
committed
Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into ndiff_update_neutral_position
Andrew Shao
committed
Undo an unnecessary change in MOM_remapping.F90
Andrew Shao
committed

Commits on Aug 8, 2017

Allow runtime option for verbose output in neutral diffusion
Andrew Shao
committed

Commits on Aug 9, 2017

Rewrite logic. Only unit test failing now is two unstable mixed layers
Andrew Shao
committed

Commits on Aug 10, 2017

Whew, finally figured out logic that passes all unit tests.
Andrew Shao
committed

Commits on Aug 11, 2017

Logic has been updated to be more consistent with the original code and
Andrew Shao
committed
Cleanup some of the code and prepare for pull request
Andrew Shao
committed
Accidentally had changed the bounds of a do-loop in the continuous case
Andrew Shao
committed

Commits on Aug 15, 2017

Create procedures for array and scalar inputs to EOS functions
Andrew Shao
committed
Make logic explicit to avoid out-of-bounds error
Andrew Shao
committed
Undo changes to continuous code that lead to answer-changes
Andrew Shao
committed