Change to pass_var for h and correct barotropic mass source#521
Merged
Conversation
Corrected a bug when DIABATIC_FIRST=True in how the compensation for the difference between the dynamic sea surface height used by the barotropic solver and the height that the layers would have if net mass sources were applied gradually instead of abruptly at the start of the thermodynamic time step. This would change answers if both SPLIT and DIABATIC_FIRST are true and the value of BT_MASS_SOURCE_LIMIT > 0.0, but as there are currently no test cases that match these conditions, the answers are unchanged in all of the test cases. In cases where the answers do change, they are unambiguously better based on weaker high frequency gravity waves arising from coupling shocks.
Corrected spelling errors and content errors in several of the comments describing subroutine arguments. All answers are bitwise identical.
Reverted to the simpler pass_var routines for the single 3-d variable h. This avoids the issue that triggered the recent pull request mom-ocean#520, and it should have no performance impacts. (In fact, by letting each call have its own halo size, it might lead to performance improvements in subsequent commits.) All answers are bitwise identical.
Collaborator
|
It's in the pipe... https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/1956 It looks like this changes the time used for some diagnostics? |
Collaborator
Author
|
Yes, this commit does change (i.e. correct) the time used for some of the bottom boundary layer properties, to reflect the fact that these properties are calculated every coupled time step, and are not constant over an entire thermodynamic time step when THERMO_SPANS_COUPLING is true. Perhaps the code itself should be revisited, but this makes the diagnostic times consistent with what is coded. |
Collaborator
|
I am testing this but the pipe keeps timing out - the machine variability
is a real pain. I know it symmetric results pass but the other tests
haven't yet made it through. If the pipe times out one more time I'll
process this PR by hand... (and raise the job length from 150% to 200% of
optimal).
…--
Dr Alistair Adcroft (Alistair.Adcroft@noaa.gov)
Princeton University Tel: (609) 987-5073
NOAA/GFDL, 201 Forrestal Road, Princeton, NJ 08540
On Thu, Jun 15, 2017 at 1:38 PM, Robert Hallberg ***@***.***> wrote:
Yes, this commit does change (i.e. correct) the time used for some of the
bottom boundary layer properties, to reflect the fact that these properties
are calculated every coupled time step, and are not constant over an entire
thermodynamic time step when THERMO_SPANS_COUPLING is true. Perhaps the
code itself should be revisited, but this makes the diagnostic times
consistent with what is coded.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<NOAA-GFDL#521 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFlo8xIWs7EUuE0ElYK0uABu27zoBDQ7ks5sEWwugaJpZM4N6g12>
.
|
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- Last commit updates available_diags and MOM_parameter_doc.all (for one expt). - NOAA-GFDL/MOM6@3486d83 Merge branch 'ashao-offline_tracer_updates' into dev/gfdl - NOAA-GFDL/MOM6@d96c87b Final changes before PR - NOAA-GFDL/MOM6@ce44698 Undo some changes made for diagnostic purposes, add comments, and cleanup code before PR - NOAA-GFDL/MOM6@d8627bc Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into offline_tracer_updates - NOAA-GFDL/MOM6@d20e897 Merge pull request mom-ocean#521 from Hallberg-NOAA/dev/gfdl - NOAA-GFDL/MOM6@a8565c7 Replaced group_pass of h with pass_var of h - NOAA-GFDL/MOM6@5daf60f Corrected typos in dOxyGen comments - NOAA-GFDL/MOM6@e8b7f0e Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl - NOAA-GFDL/MOM6@1e8c2b4 Merge pull request mom-ocean#520 from NOAA-GFDL/user/wfcooke/grouphalopass_fix - NOAA-GFDL/MOM6@db3a5b5 (*)Corrected the barotropic mass source compensation - NOAA-GFDL/MOM6@833dd84 Bugfix to reintroduce group halo pass check removed in 282a160 - NOAA-GFDL/MOM6@2b8670f Merge pull request mom-ocean#519 from Hallberg-NOAA/dev/gfdl - NOAA-GFDL/MOM6@b80fc8b Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl - NOAA-GFDL/MOM6@144daae Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl - NOAA-GFDL/MOM6@e1aed13 +Eliminated calc_bbl from the vertvisc_type - NOAA-GFDL/MOM6@0576b2b (*)Moved set_viscous_BBL out of the dynamics code - NOAA-GFDL/MOM6@53d03a7 Fixed conflicts with upstream dev/gfdl - NOAA-GFDL/MOM6@7ddc722 Added option to intersperse ALE step between horizontal advection iterations. - NOAA-GFDL/MOM6@af73ea8 Tracer now conserves when remapping input fields onto a different grid. This primarily resulted from an error in the indexing when the fields were being updated. Now to test in OM4_05 - NOAA-GFDL/MOM6@ff690d1 To aid in the debugging of tracer routines, a new subroutine is created in MOM_tracer_registry.F90: MOM_tracer_chkinv. This routine calculates the global inventories of all tracers in the registry. Some of the debugging checksums in the offline tracer routines are updated to use this new function. - NOAA-GFDL/MOM6@ab0575d Add option to skip convective readjustment when reading offline fields from z inputs - NOAA-GFDL/MOM6@f4e0063 Changes made so that regridding onto pure isopycnal kind of works. Need to figure out why the redistribution of residual does not fully conserve. - NOAA-GFDL/MOM6@d2af9df Clean up some changes that were made for development purposes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses the recent issue that triggered pull request #520, and also includes a change that improve answers in some configurations that are outside of the testing configuration.