User/mjh/fix meke#506
Merged
Hallberg-NOAA merged 8 commits intoJun 6, 2017
Merged
Conversation
- These updates apply masking of C-grid slopes and Brunt-Vaisala
frequency in order to avoid dependency on land values
- avoids dependency on land values in the calculation of lateral
mixing coefficients.
- This does not change answers for MEKE relative to the previous commit.
This is False be default and is retained for legacy purposes. Setting this to True fixes issues with erroneous k-indexing in the calulation of harmonic mean thicknesses which are applied to neutral slopes in order to compute SN_uv. This will impact answers and needs to be evaluated in existing runs with MEKE turned on.
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
Answers changed by merging in pull request User/mjh/fix meke mom-ocean#506. These changes eliminate some dependencies of the answers on land values, and they change the MOM_parameter_doc files in many test cases and the answers in the ice_ocean_SIS2/OM4_05 test case.
Hallberg-NOAA
pushed a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
Nov 8, 2023
* +Fix for issue mom-ocean#506, tracer OBC bug - it only happens in the advection for certain flow directions, inflow from OBC plus along-boundary flow. * Tracer OBCs need more of an h halo update. - This one should finally fix the processor count issues with OBCs. * Correct the "if" statement. * +Adding more halo points to an exchange - This will change answers if you start with a non-zero velocity. You need three halo points (or maybe cont_stencil) for the continuity solver. - Also trying to put in some initial DEBUG_OBC code. * Fix some DEBUG_OBC logic * Writing to temporary arrays for tres_xy - Way to trick some compiler. * Another fix for DEBUG_OBC * Fixing the whalo troubles for grids that are 2 wide/long. * Exchange all the h_new points. - without this, because we're remapping all the tres points, it dies in debug mode on bad h_new values. * Trying a different exchange - as it was, it was passing my tests, failing the auto-tests. * Fixing the DEBUG_OBC logging * Putting the logging statement back. - Making an error more verbose too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are needed to avoid land value dependence in MEKE and neutral slope calculations. Not sure if this will fix OM4_05 restart issues. Request review by @nikizadehgfdl