Converting more OBC stuff to segments.#368
Merged
Merged
Conversation
- got rid of OBC_mask_[uv] and OBC_direction_[uv]. - changed name of OBC_segment_list to OBC_segment_number.
Collaborator
Author
|
Clean up more old OBC code in favor of segments. No answer change. |
alperaltuntas
pushed a commit
to iangrooms/MOM6
that referenced
this pull request
Jul 31, 2025
Added the new routine post_tracer_integral_diagnostics to calculate vertically integrated tracer diagnostics. This includes properly setting the vertical layer extents from layer thicknesses via a call to thickness_to_dz. This new routine is being called from within step_MOM(), immediately after another closely related call to write out other tracer diagnostics. In so doing, it changes the thicknesses used for these diagnostics to be consistent with the state of the tracers. This commit also sets the appropriate unit conversion factors in the register_diag_field calls for three recently diagnostics of surface tracer concentrations and the integrated tracers amounts in the full water column and in the topmost 100 m. All solutions are bitwise identical, but this will correct the thicknesses used in the calculation of two groups of tracer diagnostics and properly implements the dimensional rescaling of these diagnostics when tracers (like temperature and salinity) when they are being rescaled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OBC segment code, no answer change but needs updates in circle_obcs and DOME experiment MOM_input files.