Specify the optional arguments passed to mpp_write_meta#25
Merged
Conversation
-The optional arguments to mpp_write_meta are not explicitly named (e.g.,foo(myunit) rather than foo(units=myunits)). The problem with that is if someone adds a new argument of the same type to the mpp_write_meta (foo(newunits,units)) then the compiler gets confused and the result may be not what you want. This senario has actually happened during testing for a FMS patch and caused crash. -The solution is to always name the optional arguments being passed.
gustavo-marques
added a commit
to gustavo-marques/MOM6
that referenced
this pull request
Sep 1, 2017
Extend restart options
raphaeldussin
pushed a commit
to raphaeldussin/MOM6
that referenced
this pull request
Dec 8, 2021
* +Rescale forcing arguments and revise ctrl_forcing This commit revisits the units of the input arguments to the various ocean- only surfaces forcing routines, including: - Rescaled the units of the time intervals passed to the various forcing routines to [T ~> s] - Applied dimensional scaling to MOM_controlled_forcing.F90. This code is not yet in active use, so these changes can not change answers, but it is now much closer to compliance with modern MOM6 standards, including improved documentation, and could be ready to try without too much more effort. - Documented the remaining real variables in benchmark_initialization.F90, along with their units. All answers are bitwise identical, but there are changes to the units of some arguments in public interfaces.
MJHarrison-GFDL
pushed a commit
to MJHarrison-GFDL/MOM6
that referenced
this pull request
Aug 16, 2022
…ve memory usage significantly. Closes mom-ocean#25.
MJHarrison-GFDL
pushed a commit
to MJHarrison-GFDL/MOM6
that referenced
this pull request
Aug 16, 2022
This update allows a user to use a CPP macro to increase the max number of files larger than 1024. Also, diag_manager will warn if the user sets the diag_manager_nml::max_files larger than allowed in mpp Fixes mom-ocean#25
MJHarrison-GFDL
pushed a commit
to MJHarrison-GFDL/MOM6
that referenced
this pull request
Aug 16, 2022
A few fixes to allow update to have diag_manager use the max number of files from mpp to compile Fixes mom-ocean#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-The optional arguments to mpp_write_meta are not explicitly named (e.g.,foo(myunit) rather than foo(units=myunits)).
The problem with that is if someone adds a new argument of the same type to the mpp_write_meta (foo(newunits,units))
then the compiler gets confused and the result may be not what you want.
This senario has actually happened during testing for a FMS patch and caused crash.
-The solution is to always name the optional arguments being passed.