62 z remapping uv grids#191
Conversation
734d9f1 to
56b2a20
Compare
43282ce to
8bc1092
Compare
218f75e to
7a990db
Compare
…urposes. This grid needs to updated everytime H changes. mom-ocean#62
7a990db to
49cd415
Compare
9f8134d to
bc8a185
Compare
|
This PR is now ready to review and merge. There should be no results change. |
There was a problem hiding this comment.
Could you move the call to diag_update_target_grids() to just after the call to continuity() so that we don't need the diag_CS type passed into continuity().
This should give just a few less calls to diag_update_target_grids() but more importantly keeps continuity look more like a computational kernel without diagnostic.
continuity(). It is not necessary to pass the diag mediator structure into calls to continuity(). mom-ocean#62
|
I have moved the calls to diag_update_target_grids() out of continuity(). This has the benefits of keeping the continuity() interface clean, and reducing unnecessary calls to diag_update_target_grids(). @adcroft can you please review etc. when you get time. |
There was a problem hiding this comment.
I gather the remapping was not accurate enough? I was quite proud of the estimate of round-off and haven't found the criteria to fail so far. Perhaps a left over from debugging?
It does the remapping for all variables on u, v grids. Altogether there are > 100 new diagnostics being remapped to Z coordinates.
This branch includes 62-z-ALE-remapping so it could be merged instead of 62-z-ALE-remapping. There a couple things that I'm not sure about in this branch: