Warn when numberOfGroundings exceeds maxGroundings#179
Merged
Conversation
In MOM_diabatic_driver, if more than maxGroundings groundings are encountered, an out-of-bounds array access will occur, likely causing a segmentation fault. This change causes only maxGroundings groundings to be printed, with a warning about the number of remaining groundings.
gustavo-marques
pushed a commit
to gustavo-marques/MOM6
that referenced
this pull request
Mar 26, 2021
Add med2mod_areacor and move where area correction is applied
MJHarrison-GFDL
pushed a commit
to MJHarrison-GFDL/MOM6
that referenced
this pull request
Aug 16, 2022
[ci skip] Add issue/pull request templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
MOM_diabatic_driver::applyBoundaryFluxesInOut(), if more thanmaxGroundingsgroundings are encountered, an out-of-bounds array access will occur, likely causing a segmentation fault. This change causes onlymaxGroundingsgroundings to be printed, with a warning about the number of remaining groundings.As an aside, am I right in thinking that a grounding occurs when some of the mass out due to fluxes is not able to be removed?