Skip to content

Changes to the diag mediator:#173

Merged
adcroft merged 1 commit into
mom-ocean:dev/masterfrom
nichannah:171-diagnostic-variations
May 14, 2015
Merged

Changes to the diag mediator:#173
adcroft merged 1 commit into
mom-ocean:dev/masterfrom
nichannah:171-diagnostic-variations

Conversation

@nichannah
Copy link
Copy Markdown
Collaborator

    1. Renaming of 'diag' variable to 'diag_cs', to avoid confusion
       with a new diag type to be introduced.
    2. Support dynamically sized diagnostic array.
    3. Introduce a generalised concept of diagnostic 'variations'.
       Each primary diagnostic can have many variations or aliases
       that are registered and posted at the same time as the
       primary. An example of this is the CMOR diagnostics.

Closes #171

@adcroft adcroft self-assigned this May 12, 2015
@adcroft
Copy link
Copy Markdown
Collaborator

adcroft commented May 12, 2015

Even with the fixed uninitialized variable I'm still getting a SEGV with all compilers for both global_ALE/layer and global_ALE/z. Unfortunately using a debug executable fixes the problem.

@nicjhan Can you try global_ALE/z yourself and see what you come up with?

        1. Renaming of 'diag' variable to 'diag_cs', to avoid confusion
           with a new diag type to be introduced.
        2. Support dynamically sized diagnostic array.
        3. Introduce a generalised concept of diagnostic 'variations'.
           Each primary diagnostic can have many variations or aliases
           that are registered and posted at the same time as the
           primary. An example of this is the CMOR diagnostics.
Closes #171
@nichannah
Copy link
Copy Markdown
Collaborator Author

This one is ready now. I have also rebased onto the latest dev/master

@adcroft adcroft merged commit 23b1a0d into mom-ocean:dev/master May 14, 2015
@nichannah nichannah deleted the 171-diagnostic-variations branch May 15, 2015 13:38
gustavo-marques added a commit to gustavo-marques/MOM6 that referenced this pull request Jan 21, 2021
Remove an omp parallel do directive due to thread-unsafe cpu_clock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants