dev emc candidate 20230122#1618
Merged
jiandewang merged 10 commits intoJan 31, 2024
Merged
Conversation
* two fields remain unresolved, sea_level and mass_overlying_ice
switch to cesm-style field names in MOM6 cap
…MAO-20231031 update MOM6 to its main repo 20231025 (NCAR candidate) and 20231031(GMAO FMS_cap) updating
…n-20231218 update MOM6 to its main 20231218 commit (disable FPEs)
- add restart_fh config variable and define restartfhtimes to enable restarts on non-interval hours - write info to stdout for documenting when additional restarts will or will not be written
Add non-interval restart capability
jiandewang
requested review from
abozec,
alperaltuntas,
kshedstrom,
marshallward and
sanAkel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
=======================================
Coverage 37.91% 37.91%
=======================================
Files 269 269
Lines 77155 77155
Branches 14164 14164
=======================================
Hits 29254 29254
Misses 42623 42623
Partials 5278 5278 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Jan 23, 2024
Collaborator
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
Looks OK; nothing we depend directly upon.
abozec
approved these changes
Jan 23, 2024
Collaborator
abozec
left a comment
abozec
left a comment
There was a problem hiding this comment.
No changes for us. COAPS approves.
Collaborator
Author
kshedstrom
approved these changes
Jan 28, 2024
Collaborator
kshedstrom
left a comment
kshedstrom
left a comment
There was a problem hiding this comment.
My tests don't depend on this code either.
Collaborator
|
I am currently testing this pr. There appears to be a small but consistent slow down ( 2-3%) that I am trying to track down. Will keep you updated. |
Collaborator
Author
|
thanks for everbody's time and effect, I am going to merge this to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two NUOPC cap enhancements:
(1) switch to cesm style field names so that field names were aligned with those in https://github.com/ESCOMP/CMEPS/blob/main/mediator/fd_cesm.yaml (see detail at NOAA-EMC#120)
(2) add non-interval restart writing capability: this requirement is from EMC DA group which requires to write out restart files at irregular time frequency. (see detail at ufs-community/ufs-weather-model#1976)
both of the them have been pre-tested from NCAR side (thanks @alperaltuntas)