FMS_cap: extract c-grid staggered currents#1611
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage 38.17% 38.17%
=======================================
Files 269 269
Lines 76503 76503
Branches 14064 14064
=======================================
Hits 29202 29202
Misses 42054 42054
Partials 5247 5247 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jiandewang
left a comment
There was a problem hiding this comment.
in UFS it only nuopc_cap so this change won't have any impact to us.
abozec
left a comment
There was a problem hiding this comment.
COAPS approves. This change does not impact our set-up.
marshallward
left a comment
There was a problem hiding this comment.
This passes our regression test, and appears to be safe.
(Index capitalization in mask2dC[uv] may need a revision at some point, however,)
@marshallward Feel free to capitalize/ push an update. Anyway you'll have to update the branch. |
|
It's fine for now. I don't want to change the GEOS |
|
@gustavo-marques, @alperaltuntas would you please comment on this PR. Thanks! |
|
Apologies for the delay. We approve this PR. |
|
Thanks @gustavo-marques. @marshallward please update/rebase this branch, I can't do it myself via github - write permissions? |
|
Ah because it's out of date... you could fix this by merging |
|
Requiring that branches be up-to-date feels incorrect, since we don't require partner branches to be using We can talk more at a future dev call if there are any potential problems with relaxing this rule. |
This PR adds an option:
FMS_capto extractucandvccurrents.Notes:
@jiandewang, @gustavo-marques, @alperaltuntas and @abozec,
AFAIK you do not use
FMS_cap, so hopefully this is irrelevant to your use cases.@marshallward, @Hallberg-NOAA, @kshedstrom:
Appreciate your comments.