add run time information in NUOPC cap#1608
Conversation
…n-20230504 update to MOM6 main 20230504 updating
…n-20230811 update to MOM6 main 20230731 and 20230811 updating
* add optional run time info in nuopc cap. Author: Jun Wang
Codecov Report
@@ Coverage Diff @@
## main #1608 +/- ##
=======================================
Coverage 38.17% 38.17%
=======================================
Files 269 269
Lines 76503 76503
Branches 14064 14064
=======================================
+ Hits 29202 29204 +2
+ Misses 42054 42052 -2
Partials 5247 5247 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
marshallward
left a comment
There was a problem hiding this comment.
I am approving this, but I would like to repeat my concern about using MPI_Wtime in this driver. The function can become blocking if certain flags are set, which will block across the entire MPI_COMM_WORLD, not just MOM6. If other ranks are not calling MPI_Wtime, then the model will hang.
We recognize that your groups are maintaining the NUOPC cap, so I won't let this concern hold up the patch. But if a future NUOPC user encounters problems with this, then we may want to revisit this change.
abozec
left a comment
There was a problem hiding this comment.
We don't use the NUOPC cap in our applications, so it won't affect us.
kshedstrom
left a comment
There was a problem hiding this comment.
This code doesn't affect me either.
|
thanks for everybody's time and effect, I am going to merge it |
this mini PR added some run time information in NUOPC cap for us to monitor the UFS running speed. A logic variable "write_runtimelog" is added here with default value of False. As usual I am asking MOM6 major users for the review although only NCAR may use this feature (and we asked @alperaltuntas and @marshallward for a pre-review before this formal PR). Thanks for your very helpful suggestions.