update how UFS names restart files#1593
Conversation
* write all restarts as YYYYMMDD.HHMMSS.MOM.resX * includes stoch restarts * write final restart with timestamp * change nems=>ufs
…n-20230206 update to MOM6 main 20230206 commit
…enames update how UFS names restarts
jiandewang
requested review from
abozec,
alperaltuntas,
kshedstrom,
marshallward and
sanAkel
Codecov Report
@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
+ Coverage 35.91% 37.22% +1.30%
==========================================
Files 260 263 +3
Lines 72016 73074 +1058
Branches 13593 13608 +15
==========================================
+ Hits 25867 27203 +1336
+ Misses 41101 40864 -237
+ Partials 5048 5007 -41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
As noted, these changes are limited in their scope to the NUOPC coupler- that seem reasonable for the said purpose.
(However, if I may suggest, rather than doing this way, touching Coupler that spans outside the UFS utility, perhaps best to have flexibility in your UFS workflow tool- anyway do as you wish!)
alperaltuntas
left a comment
alperaltuntas
left a comment
There was a problem hiding this comment.
No impact on CESM.
kshedstrom
left a comment
kshedstrom
left a comment
There was a problem hiding this comment.
The indentation is not according to MOM6 guidelines in config_src/drivers/nuopc_cap/mom_cap.F90, lines 1702-1705
I'll approve subject to this being fixed.
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
GFDL approves this PR.
We agree with @kshedstrom with respect to whitespace in the write() statements (specifically after commas), but we're OK with fixing this up in a later PR.
|
thanks for all reviewers' quick action, we will fix the extra whitespace in a later PR. |
7 participants
in order to have an unified style of restart file naming among UFS sub components, this mini PR
the code changes are only within ufs loop in nuopc drive so it's unlikely to have impact for other users.
As usual we ask reviewers to help us check the code to make sure it won't break your current settings.